[#59] Add node states #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maypok86
force-pushed
the
maypok86/#59-node-state
branch
from
5069da5 to
6bb9e32
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 95.37% 95.62% +0.25%
==========================================
Files 22 22
Lines 1232 1235 +3
==========================================
+ Hits 1175 1181 +6
+ Misses 39 36 -3
Partials 18 18 ☔ View full report in Codecov by Sentry. |
|
Damn, it seems like splitting isAlive checks between eviction and expiration policies was a bad idea. It looks like we need to refactor the code. |
maypok86
force-pushed
the
maypok86/#59-node-state
branch
from
edd28dd to
03b6bf0
Compare
|
Yes, it looks better now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A state has been added to each node. (Whether it was deleted from the hash table or not).
This will help filter events for eviction policy updates in the wrong order to avoid damaging the eviction policy.
Related issue(s)
✅ Checklist for your Pull Request
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Public contracts
Stylistic guide (mandatory)
My code complies with the styles guide.
My commit history is clean (only contains changes relating to my
issue/pull request and no reverted-my-earlier-commit changes) and commit
messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit descriptionIf necessary both of these can be achieved even after the commits have been
made/pushed using rebase and squash.
Before merging (mandatory)